[14.0][ADD] product_multi_barcode_constraint_per_company: add module #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessanhemrayev
force-pushed
the
14.0-t2944-product_multi_barcode_constraint_per_company-bridge_module
branch
18 times, most recently
from
51df296 to
6cc4f18
Compare
|
Following this @legalsylvain 's comment. |
dessanhemrayev
force-pushed
the
14.0-t2944-product_multi_barcode_constraint_per_company-bridge_module
branch
10 times, most recently
from
affa192 to
bda8432
Compare
dessanhemrayev
force-pushed
the
14.0-t2944-product_multi_barcode_constraint_per_company-bridge_module
branch
5 times, most recently
from
3ef6439 to
11a15df
Compare
geomer198
reviewed
Nov 1, 2023
| @api.constrains("name") | ||
| def _check_duplicates(self): | ||
| for record in self: | ||
| barcodes = self.search( |
There was a problem hiding this comment.
Could you add a limit parameter?
barcodes = self.search([...], limit=1)
geomer198
reviewed
Nov 1, 2023
|
|
||
|
|
||
| @tagged("post_install", "-at_install") | ||
| class TestProductBarcodeConstraintInherit(TestModule): |
There was a problem hiding this comment.
For each tests need docstring and assertion message.
dessanhemrayev
force-pushed
the
14.0-t2944-product_multi_barcode_constraint_per_company-bridge_module
branch
4 times, most recently
from
2950ae7 to
e62aea3
Compare
geomer198
suggested changes
Nov 6, 2023
| @@ -0,0 +1 @@ | |||
| This is a bridge module between "product_barcode_constraint_per_company" and "product_multi_barcode" | |||
There was a problem hiding this comment.
Should be remove this file. News fragments using for updating module not for creating.
dessanhemrayev
force-pushed
the
14.0-t2944-product_multi_barcode_constraint_per_company-bridge_module
branch
from
fffbd4d to
557d86d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bridge module between "product_multi_barcode" and "product_barcode_constraint_per_company"